Made various improvements to the workspaces module. (#17)

* Made workspace scrolling slower and more natural.

* Fix workspace scrolling not working on single monitors: Fixes #8

* Fixed #15 and added configuration options to adjust workspace spacing and scrolling speed.
This commit is contained in:
Jas Singh
2024-07-28 01:44:00 -07:00
committed by GitHub
parent a8d3bd286a
commit 033fbe6947
5 changed files with 53 additions and 39 deletions

View File

@@ -2,7 +2,7 @@ const hyprland = await Service.import("hyprland");
import { WorkspaceRule, WorkspaceMap } from "lib/types/workspace"; import { WorkspaceRule, WorkspaceMap } from "lib/types/workspace";
import options from "options"; import options from "options";
const { workspaces, monitorSpecific, reverse_scroll } = options.bar.workspaces; const { workspaces, monitorSpecific, reverse_scroll, scroll_speed, spacing } = options.bar.workspaces;
function range(length: number, start = 1) { function range(length: number, start = 1) {
return Array.from({ length }, (_, i) => i + start); return Array.from({ length }, (_, i) => i + start);
@@ -43,6 +43,10 @@ const Workspaces = (monitor = -1, ws = 8) => {
}; };
const getCurrentMonitorWorkspaces = () => { const getCurrentMonitorWorkspaces = () => {
if (hyprland.monitors.length === 1) {
return Array.from({ length: workspaces.value }, (_, i) => i + 1);
}
const monitorWorkspaces = getWorkspaceRules(); const monitorWorkspaces = getWorkspaceRules();
const monitorMap = {}; const monitorMap = {};
hyprland.monitors.forEach((m) => (monitorMap[m.id] = m.name)); hyprland.monitors.forEach((m) => (monitorMap[m.id] = m.name));
@@ -79,6 +83,39 @@ const Workspaces = (monitor = -1, ws = 8) => {
hyprland.messageAsync(`dispatch workspace ${currentMonitorWorkspaces.value[prevIndex]}`) hyprland.messageAsync(`dispatch workspace ${currentMonitorWorkspaces.value[prevIndex]}`)
} }
function throttle<T extends (...args: any[]) => void>(func: T, limit: number): T {
let inThrottle: boolean;
return function (this: ThisParameterType<T>, ...args: Parameters<T>) {
if (!inThrottle) {
func.apply(this, args);
inThrottle = true;
setTimeout(() => {
inThrottle = false;
}, limit);
}
} as T;
}
const createThrottledScrollHandlers = (scrollSpeed: number) => {
const throttledScrollUp = throttle(() => {
if (reverse_scroll.value === true) {
goToPrevWS();
} else {
goToNextWS();
}
}, 200 / scrollSpeed);
const throttledScrollDown = throttle(() => {
if (reverse_scroll.value === true) {
goToNextWS();
} else {
goToPrevWS();
}
}, 200 / scrollSpeed);
return { throttledScrollUp, throttledScrollDown };
}
return { return {
component: Widget.Box({ component: Widget.Box({
class_name: "workspaces", class_name: "workspaces",
@@ -95,6 +132,7 @@ const Workspaces = (monitor = -1, ws = 8) => {
}) })
.map((i) => { .map((i) => {
return Widget.Button({ return Widget.Button({
class_name: "workspace-button",
on_primary_click: () => { on_primary_click: () => {
hyprland.messageAsync(`dispatch workspace ${i}`) hyprland.messageAsync(`dispatch workspace ${i}`)
@@ -102,6 +140,7 @@ const Workspaces = (monitor = -1, ws = 8) => {
child: Widget.Label({ child: Widget.Label({
attribute: i, attribute: i,
vpack: "center", vpack: "center",
css: spacing.bind("value").as(sp => `margin: 0rem ${0.375 * sp}rem;`),
class_name: Utils.merge( class_name: Utils.merge(
[ [
options.bar.workspaces.show_icons.bind("value"), options.bar.workspaces.show_icons.bind("value"),
@@ -173,23 +212,14 @@ const Workspaces = (monitor = -1, ws = 8) => {
}), }),
isVisible: true, isVisible: true,
boxClass: "workspaces", boxClass: "workspaces",
useBox: true,
props: { props: {
setup: (self: any) => {
on_scroll_up: () => { self.hook(scroll_speed, () => {
if (reverse_scroll.value === true) { const { throttledScrollUp, throttledScrollDown } = createThrottledScrollHandlers(scroll_speed.value);
goToPrevWS(); self.on_scroll_up = throttledScrollUp;
} else { self.on_scroll_down = throttledScrollDown;
goToNextWS(); });
} }
},
on_scroll_down: () => {
if (reverse_scroll.value === true) {
goToNextWS();
} else {
goToPrevWS();
}
},
} }
}; };
}; };

View File

@@ -6,18 +6,6 @@ export const BarItemBox = (child) => {
return child.isVisible; return child.isVisible;
}; };
if (Object.hasOwnProperty.call(child, "useBox") && child.useBox === true) {
return Widget.Box({
class_name: `bar_item_box_visible ${Object.hasOwnProperty.call(child, "boxClass") ? child.boxClass : ""}`,
child: Widget.EventBox({
class_name: `bar-event-box`,
child: child.component,
...child.props,
}),
visible: computeVisible(),
});
}
return Widget.Button({ return Widget.Button({
class_name: `bar_item_box_visible ${Object.hasOwnProperty.call(child, "boxClass") ? child.boxClass : ""}`, class_name: `bar_item_box_visible ${Object.hasOwnProperty.call(child, "boxClass") ? child.boxClass : ""}`,
child: child.component, child: child.component,

View File

@@ -577,8 +577,10 @@ const options = mkOptions(OPTIONS, {
occupied: opt(""), occupied: opt(""),
}, },
workspaces: opt(10), workspaces: opt(10),
spacing: opt(1),
monitorSpecific: opt(true), monitorSpecific: opt(true),
reverse_scroll: opt(false), reverse_scroll: opt(false),
scroll_speed: opt(5),
}, },
volume: { volume: {
label: opt(true), label: opt(true),

View File

@@ -2,14 +2,6 @@
@import '../../variables'; @import '../../variables';
.workspaces { .workspaces {
button {
margin: 0rem 0.5rem * .5;
&:not(:first-child) {
margin-left: 0.7em;
}
}
label { label {
font-size: 0.2em; font-size: 0.2em;
min-width: 4em; min-width: 4em;
@@ -38,8 +30,8 @@
min-width: 0em; min-width: 0em;
min-height: 0em; min-height: 0em;
border-radius: 0em; border-radius: 0em;
font-size: 1.1em; transition: 300ms * .5;
font-size: 1em;
} }
} }
} }

View File

@@ -22,9 +22,11 @@ export const BarSettings = () => {
Option({ opt: options.bar.workspaces.icons.available, title: 'Workspace Available', type: 'string' }), Option({ opt: options.bar.workspaces.icons.available, title: 'Workspace Available', type: 'string' }),
Option({ opt: options.bar.workspaces.icons.active, title: 'Workspace Active', type: 'string' }), Option({ opt: options.bar.workspaces.icons.active, title: 'Workspace Active', type: 'string' }),
Option({ opt: options.bar.workspaces.icons.occupied, title: 'Workspace Occupied', type: 'string' }), Option({ opt: options.bar.workspaces.icons.occupied, title: 'Workspace Occupied', type: 'string' }),
Option({ opt: options.bar.workspaces.spacing, title: 'Spacing', subtitle: 'Spacing between workspace icons', type: 'float' }),
Option({ opt: options.bar.workspaces.workspaces, title: 'Total Workspaces', type: 'number' }), Option({ opt: options.bar.workspaces.workspaces, title: 'Total Workspaces', type: 'number' }),
Option({ opt: options.bar.workspaces.monitorSpecific, title: 'Monitor Specific', subtitle: 'Only workspaces applicable to the monitor will be displayed', type: 'boolean' }), Option({ opt: options.bar.workspaces.monitorSpecific, title: 'Monitor Specific', subtitle: 'Only workspaces applicable to the monitor will be displayed', type: 'boolean' }),
Option({ opt: options.bar.workspaces.reverse_scroll, title: 'Invert Scroll', subtitle: 'Scrolling up will go to the previous workspace rather than the next.', type: 'boolean' }), Option({ opt: options.bar.workspaces.reverse_scroll, title: 'Invert Scroll', subtitle: 'Scrolling up will go to the previous workspace rather than the next.', type: 'boolean' }),
Option({ opt: options.bar.workspaces.scroll_speed, title: 'Scrolling Speed', type: 'number' }),
Header('Volume'), Header('Volume'),
Option({ opt: options.bar.volume.label, title: 'Show Volume Percentage', type: 'boolean' }), Option({ opt: options.bar.volume.label, title: 'Show Volume Percentage', type: 'boolean' }),